revise failure text #214
revise failure text #214
Conversation
Trott
commented
Feb 26, 2019
- Correct spelling of occurred.
- Capitalize first word.
- Add punctuation.
* Correct spelling of _occurred_. * Capitalize first word. * Add punctuation.
|
/ping @nodejs/github-bot |
| @@ -109,7 +109,7 @@ function triggerBuildIfValid (options) { | |||
| triggerBuild(options, function onBuildTriggered (err, buildUrl) { | |||
| if (err) { | |||
| logger.error(err, 'Error while triggering Jenkins build') | |||
| return createPrComment(options, `@${options.author} sadly an error occured when I tried to trigger a build :(`) | |||
| return createPrComment(options, `@${options.author} Sadly, an error occurred when I tried to trigger a build. :(`) | |||
There was a problem hiding this comment.
nit: sadly is not the first word in the sentence, the hail is.
There was a problem hiding this comment.
I think it's debatable whether that is part of the sentence or simply something put there to notify the right person/get their attention. I wouldn't write: "Refael sadly an error occurred." It would be "Refael, sadly an error occurred." Or "Refael: Sadly an error occurred." The lack of punctuation after the hail makes it seem to me more "correct" to say that it is not part of the sentence. But that's certainly only my opinion and others may surely disagree.
¯\(ツ)/¯
If I had my druthers, it would probably be a colon: @example: Sadly, an error occurred. If that seems good to you, I'd be happy to do that.