Skip to content

labels: add ES Modules #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 28, 2019
Merged

labels: add ES Modules #249

merged 1 commit into from
Dec 28, 2019

Conversation

DerekNonGeneric
Copy link
Contributor

Resolves: nodejs/modules#460

Perhaps changing the name of this label to esm would save effort in the long run.

/cc @MylesBorins

@phillipj phillipj merged commit cfd626f into nodejs:master Dec 28, 2019
@phillipj
Copy link
Member

These changes are live 🚀

(the bot auto redeploys on merge to master)

@DerekNonGeneric
Copy link
Contributor Author

DerekNonGeneric commented Dec 28, 2019

@phillipj, @Trott, do I need to be a member of TestOrgPleaseIgnore to carry out the test described in the README? It's a bit unclear to me what the procedure is to test the labeling script. Any tips?

@phillipj
Copy link
Member

@DerekNonGeneric sorry for the late reply, didn't see you follow-up question there!

I'll be honest and say it's years since I did end-to-end testing via the TestOrgPleaseIgnore and the SSE_RELAY configuration described in the README. For things like adding/fixing these labels, I rely on the related unit tests.

I do believe you have got to be a member of that org to be allowed to add labels to incoming PRs inside that TestOrgPleaseIgnore via your GitHub token.

Let me know if you want to be added to that org and I'll invite you.

@DerekNonGeneric
Copy link
Contributor Author

@phillipj, I am still very much interested in figuring out how to test this bot. I would appreciate membership to assist with testing. The README may need some work. I hope I can reach out if I get stuck.

@phillipj
Copy link
Member

✅ invite sent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update node.js github bot to auto label modules issues
3 participants