Skip to content

feat(stale): also close discussions #4620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

avivkeller
Copy link
Member

Now that this repository is going to be hosting the Node.js discussions, I think it'd be nice to have a stalebot to regulate said discussions.

@avivkeller
Copy link
Member Author

This PR has been open for 7 days with no objections.

Just confirming with @nodejs/actions this external action is okay?

@richardlau
Copy link
Member

Just confirming with @nodejs/actions this external action is okay?

cc @nodejs/security-wg

@marco-ippolito
Copy link
Member

it doesnt seems very popular https://github.com/steffen-karlsson/stalesweeper 😐 I'd rather use something maintained and with a community

@avivkeller
Copy link
Member Author

avivkeller commented Apr 24, 2025

I would as well, but I literally could not find a single other action that did this.

sylwek78

This comment was marked as spam.

@avivkeller
Copy link
Member Author

avivkeller commented Apr 29, 2025

Confirming the best course of action here?

👎 No stale bot

👍 Use the 3rd-party stale bot.

I've done a look through of the stale bot and I don't see any issues security-wise. Plus, since it's SHA pinned, we can be sure the content matches our expectations.

❤️ Create a 1st-party stale bot for discussions (like a script for this workflow to call, stored under .github)

For any action, in a worst case scenario, the impact is minimal: the worst thing a potential attacker would be able to do would be editing issues/discussions/PRs in this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants