Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: don't penalize setInterval/setTimeout common case #1221

Merged
merged 3 commits into from
Mar 21, 2015
Merged

lib: don't penalize setInterval/setTimeout common case #1221

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31da975
lib: don't penalize setTimeout() common case
bnoordhuis Mar 20, 2015
33fea6e
lib: don't penalize setInterval() common case
bnoordhuis Mar 20, 2015
2b3b2d3
test: add setTimeout/setInterval multi-arg tests
bnoordhuis Mar 20, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: add setTimeout/setInterval multi-arg tests 
It turns out we have little to no test coverage for setTimeout() and
setInterval() calls with optional arguments.  Now we do.

PR-URL: #1221
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
  • Loading branch information
@bnoordhuis
bnoordhuis committed Mar 20, 2015
commit 2b3b2d392fbd11ce8af53b8ac5185da793f0304f
30 changes: 30 additions & 0 deletions test/parallel/test-timers-args.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
var common = require('../common');
var assert = require('assert');

function range(n) {
return 'x'.repeat(n + 1).split('').map(function(_, i) { return i; });
}

function timeout(nargs) {
var args = range(nargs);
setTimeout.apply(null, [callback, 1].concat(args));

function callback() {
assert.deepEqual([].slice.call(arguments), args);
if (nargs < 128) timeout(nargs + 1);
}
}

function interval(nargs) {
var args = range(nargs);
var timer = setTimeout.apply(null, [callback, 1].concat(args));

function callback() {
clearInterval(timer);
assert.deepEqual([].slice.call(arguments), args);
if (nargs < 128) interval(nargs + 1);
}
}

timeout(0);
interval(0);