Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: Checking this.connection is not null before using #2172

Closed
wants to merge 1 commit into from
Closed

http: Checking this.connection is not null before using #2172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
http: Checking this.connection is not null before using 
Fixes: nodejs/node-v0.x-archive#25670
  • Loading branch information
@thefourtheye
thefourtheye committed Jul 13, 2015
commit 1fb234e6ab90533a92e794a27775608161019e39
4 changes: 3 additions & 1 deletion lib/_http_outgoing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,7 +571,9 @@ OutgoingMessage.prototype.end = function(data, encoding, callback) {
// There is the first message on the outgoing queue, and we've sent
// everything to the socket.
debug('outgoing message end.');
if (this.output.length === 0 && this.connection._httpMessage === this) {
if (this.output.length === 0 &&
this.connection &&
this.connection._httpMessage === this) {
this._finish();
}

Expand Down