Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove check for valid hostname in test-dns.js #2785

Closed
wants to merge 1 commit into from
Closed

test: remove check for valid hostname in test-dns.js #2785

wants to merge 1 commit into from

Commits on Sep 10, 2015

  1. test: remove check for valid hostname in test-dns.js 

    Operating systems can and do return invalid hostnames if that's
what they have (for example) in /etc/hosts. Test passes if no
error is thrown and the hostname string is not empty.

Fixes: nodejs#2468
    @Trott
    Trott committed Sep 10, 2015
    Configuration menu
    Copy the full SHA
    cd12f23 View commit details
    Browse the repository at this point in the history