-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
process: add process.features.require_module #55241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
process: add process.features.require_module #55241
Conversation
Review requested:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55241 +/- ##
==========================================
- Coverage 88.41% 88.41% -0.01%
==========================================
Files 652 652
Lines 186612 186615 +3
Branches 36062 36061 -1
==========================================
+ Hits 165001 165003 +2
+ Misses 14885 14879 -6
- Partials 6726 6733 +7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
https://github.com/nodejs/node/actions/runs/11147823375/job/30983051322?pr=55241#step:7:6106
|
For detecting whether `require(esm)` is supported without triggering the experimental warning.
a40f0ad
to
1609e78
Compare
@aduh95 @mcollina @richardlau CI is green - can I get some re-approvals to help it make it into v23? As for #55241 (comment) - I don't think the request to repeat the documentation with a false condition is blocking. Feel free to open a follow-up PR if you feel the addition is necessary. @aduh95 |
Backport in #56927 |
For detecting whether
require(esm)
is supported without triggering the experimental warning.