tools: small edits to create-release-proposal workflow
#56540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small cleanup edits.
|
Review requested:
|
richardlau
approved these changes
Jan 9, 2025
marco-ippolito
approved these changes
Jan 10, 2025
RafaelGSS
approved these changes
Jan 10, 2025
lpinca
approved these changes
Jan 10, 2025
juanarbol
approved these changes
Jan 10, 2025
jasnell
approved these changes
Jan 11, 2025
|
Landed in 7409a1d |
This was referenced Jan 28, 2025
Merged
This was referenced Mar 17, 2025
This was referenced Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those are basically nits, but here's a PR anyway:
echo '{}'intojqis pure overhead, we can use--null-input/-ninstead.create-release.shname is a bit misleading, it only creates a proposal, so IMO it makes sense to align with the workflow name.