doc: correct status of require(esm) warning in v20 changelog #57529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The backported patches already include the commit that disables the warning unless `--trace-require-module` is explicitly used. Correct the changelog to match the status.
marco-ippolito
approved these changes
Mar 18, 2025
richardlau
approved these changes
Mar 18, 2025
|
Fast-track has been requested by @joyeecheung. Please 👍 to approve. |
lpinca
approved these changes
Mar 18, 2025
|
Landed in fe5817e |
5 tasks
|
I've updated https://github.com/nodejs/node/releases/tag/v20.19.0 and opened nodejs/nodejs.org#7556 |
aduh95
pushed a commit
that referenced
this pull request
Mar 22, 2025
The backported patches already include the commit that disables the warning unless `--trace-require-module` is explicitly used. Correct the changelog to match the status. PR-URL: #57529 Fixes: #57517 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 1, 2025
The backported patches already include the commit that disables the warning unless `--trace-require-module` is explicitly used. Correct the changelog to match the status. PR-URL: #57529 Fixes: #57517 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 1, 2025
The backported patches already include the commit that disables the warning unless `--trace-require-module` is explicitly used. Correct the changelog to match the status. PR-URL: #57529 Fixes: #57517 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backported patches already include the commit that disables the warning unless
--trace-require-moduleis explicitly used. Correct the changelog to match the status.Fixes: #57517