sea: support execArgv in sea config #59314
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
jasnell
reviewed
Aug 1, 2025
addaleax
approved these changes
Aug 4, 2025
The `execArgv` field can be used to specify Node.js-specific arguments that will be automatically applied when the single executable application starts. This allows application developers to configure Node.js runtime options without requiring end users to be aware of these flags.
addaleax
approved these changes
Aug 12, 2025
Commit Queue failed- Loading data for nodejs/node/pull/59314 ✔ Done loading data for nodejs/node/pull/59314 ----------------------------------- PR info ------------------------------------ Title sea: support execArgv in sea config (#59314) Author Joyee Cheung <joyeec9h3@gmail.com> (@joyeecheung) Branch joyeecheung:sea-cli -> nodejs:main Labels c++, author ready, needs-ci, single-executable Commits 1 - sea: support execArgv in sea config Committers 1 - Joyee Cheung <joyeec9h3@gmail.com> PR-URL: https://github.com/nodejs/node/pull/59314 Refs: https://github.com/nodejs/node/issues/51688 Refs: https://github.com/nodejs/node/issues/55573 Refs: https://github.com/nodejs/single-executable/issues/100 Reviewed-By: Anna Henningsen <anna@addaleax.net> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/59314 Refs: https://github.com/nodejs/node/issues/51688 Refs: https://github.com/nodejs/node/issues/55573 Refs: https://github.com/nodejs/single-executable/issues/100 Reviewed-By: Anna Henningsen <anna@addaleax.net> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 01 Aug 2025 13:18:06 GMT ✔ Approvals: 1 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/59314#pullrequestreview-3111580320 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2025-08-11T09:44:55Z: https://ci.nodejs.org/job/node-test-pull-request/68557/ - Querying data for job/node-test-pull-request/68557/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/16914688343 |
|
Removed the unused variable that triggered |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #59314 +/- ##
=======================================
Coverage ? 89.86%
=======================================
Files ? 656
Lines ? 193012
Branches ? 37860
=======================================
Hits ? 173449
Misses ? 12117
Partials ? 7446
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
execArgvfield can be used to specify Node.js-specific arguments that will be automatically applied when the single executable application starts. This allows application developers to configure Node.js runtime options without requiring end users to be aware of these flags.This implements point 1 in #51688 (comment) - and leaves point 2 open, which can be implemented together or as a follow-up. It would be helpful to get some feedback about whether that plan is good enough for different use cases before I send this for code review. Currently the behavior in this PR is point 1 + the "env" option in point 2 by default.
Refs: #51688
Refs: #55573
Refs: nodejs/single-executable#100