Fix comparison and really emit trace logs (treeverse#1283)

arielshaqed · web-flow · commit d29d82e02a21 · 2021-01-21T18:56:18.000+02:00
diff --git a/logging/logger.go b/logging/logger.go
@@ -135,8 +135,8 @@ func (l *logrusEntryWrapper) Panicf(format string, args ...interface{}) {
 	l.e.Panicf(format, args...)
 }
 
-func (l *logrusEntryWrapper) IsTracing() bool {
-	return l.e.Level < logrus.TraceLevel
+func (*logrusEntryWrapper) IsTracing() bool {
+	return logrus.IsLevelEnabled(logrus.TraceLevel)
 }
 
 type logrusCallerFormatter struct {

Original file line number	Diff line number	Diff line change
`@@ -135,8 +135,8 @@ func (l *logrusEntryWrapper) Panicf(format string, args ...interface{}) {`
`135`	`135`	`l.e.Panicf(format, args...)`
`136`	`136`	`}`
`137`	`137`
`138`		`-func (l *logrusEntryWrapper) IsTracing() bool {`
`139`		`- return l.e.Level < logrus.TraceLevel`
	`138`	`+func (*logrusEntryWrapper) IsTracing() bool {`
	`139`	`+ return logrus.IsLevelEnabled(logrus.TraceLevel)`
`140`	`140`	`}`
`141`	`141`
`142`	`142`	`type logrusCallerFormatter struct {`