Fix accessibility issue #9165 on color contrast ratio #1270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please use |
leobalter
requested changes
Sep 12, 2024
leobalter
approved these changes
Sep 12, 2024
|
spot check and links are now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
What
This pull request includes change to the
src/theme.jsfile to fix an accessibility issue related to color contrast ratio betweennpm linktext #cb0000 andsurrounding text#1f2328Why
If the link has no distinct style (such as underline) and luminosity contrast of the link has insufficient contrast ratio with the surrounding text. As a result, users with low vision who experience low contrast cannot detect visually that the text is intended to function as a link.
Accessibility improvements:
src/theme.js: Changed thenpm themecolor from#cb0000to#cb3837to meet the minimum contrast 3:1