fix(search): Don't crash the page if a starts a search with the letter "H" #1351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is crazy 😆 , thank you so much 🙏 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue (#1333) from a couple weeks ago explains the problem pretty thoroughly so if you want more info just look there.
The short version though is that when
hookswere deprecated a few months ago it surfaced an issue where if a query has a result that has nohierarchymatches the entire page will crash when the dropdown element for the result tries to generate breadcrumbs.References
Fixes #1333
Additional Notes
I do want to mention that now that you can search for "hooks" without the page crashing, you can now get to the Hooks page for
v10and the variant dropdown on there behaves a little weird since it can't map a the pages path to a version variant.