Skip to content

Changed style for focused VarianSelect element #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2022
Merged

Changed style for focused VarianSelect element #248

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88e82e7
changed style for focused VarianSelect element
pavlov-kirill Oct 13, 2022
286bc4a
Merge branch 'main' into 2791-dropdown-ratio
pavlov-kirill Oct 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions theme/src/components/variant-select.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,19 @@

import React from 'react';
import styled from 'styled-components';
import { Dropdown } from '@primer/components';
import { Dropdown, themeGet } from '@primer/components';
import NavHierarchy from '../nav-hierarchy'

VariantSelect.Menu = styled(Dropdown.Menu)`
width: ${props => props.width ? props.width : '160px'};
`

VariantSelect.Button = styled(Dropdown.Button)`
&:focus {
box-shadow: 0 0 0 3px ${themeGet('colors.blue.5')};
}
`

function VariantSelect(props) {
const path = NavHierarchy.getPath(props.location.pathname);
const vp = NavHierarchy.getVariantAndPage(props.root, path);
Expand Down Expand Up @@ -67,7 +73,7 @@ function VariantSelect(props) {

return (
<Dropdown onKeyDown={onDropDownKeyDown} overlay={props.overlay}>
<Dropdown.Button>{selectedItem.variant.title}</Dropdown.Button>
<VariantSelect.Button>{selectedItem.variant.title}</VariantSelect.Button>
<VariantSelect.Menu direction={props.direction} width={props.menuWidth}>
{items}
</VariantSelect.Menu>
Expand Down