docs: docker-and-private-modules #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example of how to use `--secret` flag to not expose your npm token in the final docker image.
|
@MylesBorins I think you were concerned about that Docker image not working on CI? This works for me with GitHub Actions: - name: Build and Push Docker image
run: |
echo "//registry.npmjs.org/:_authToken=${{ secrets.NPM_TOKEN }}" > .npmrc
docker buildx build . -f Dockerfile -t ${{ secrets.DOCKER_USERNAME }}/${{ secrets.DOCKER_REPOSITORY }} --secret id=npmrc,src=.npmrc --pushYou have to of course set-up other steps for it like docker buildx, logging to docker etc. but that is GitHub Actions specific. The point in question is that this can work on CI. |
|
@MylesBorins @monishcm I've tried to address the previous concerns but maybe I could improve this PR in any way? |
MylesBorins
approved these changes
Mar 16, 2023
content/integrations/integrating-npm-with-external-services/docker-and-private-modules.mdx
Outdated
Show resolved
Hide resolved
…cker-and-private-modules.mdx
|
@matzar this looks good now. I'm going to test the new instructions locally and then assuming it all works land this |
|
Thanks for all the hard work and patience on seeing this through! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@MylesBorins the previous PRs have pivoted too much and their goal was not stated clearly. This is my fault so this is a final PR that will attempt to clearly and shorty state its purpose and what problems it's trying to fix.
The reason behind this PR is to securely download private npm packages when building a docker image and address the pitfalls with the current set-up in the documentation which are also explained in this article.
Current set-up will save your npm token in the final docker image. This PR solves that problem by showing you how to use the
--secretflag with thedocker buildcommand and not have your npm token saved in your final docker image.