Skip to content

Conversation

makhmudjon-inadullaev
Copy link
Contributor

  • Add visible text above the version selection control saying Select CLI Version:
  • Visible text's DOM element should have a unique id
  • The <details> element should have aria-labelledby= pointing to the new text's id value

References

https://github.com/github/accessibility-audits/issues/2748#issue-1324085140

@makhmudjon-inadullaev
Copy link
Contributor Author

@lindseywild Let me know for any changes we can add here? Thanks.

@lindseywild
Copy link

This looks like it satisfies the acceptance criteria, thanks!

@makhmudjon-inadullaev makhmudjon-inadullaev merged commit efc48c5 into main Nov 1, 2022
@makhmudjon-inadullaev makhmudjon-inadullaev deleted the fixing/suggestions branch November 1, 2022 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants