-
Notifications
You must be signed in to change notification settings - Fork 3k
Progress bar noticeably slows down npm install #11283
Comments
I found the original report here whilst researching how I could make |
It seems to yield a significant speed up for most people, all my colleagues in @intercom are seeing a significant boost. So far @kittens is the only one who hasn't reported a big difference: https://twitter.com/sebmck/status/691911481114415104 I tried
|
Looks like there's something in the works that might help: https://github.com/iarna/gauge/issues/7#issuecomment-171474156 |
Same here. I'm running local-npm so I can rule out any network related issues:
That's a 41% increase in total time. |
Same here
Computer specs:
|
Minor difference in my case: https://gist.github.com/Reinmar/f69303b79157f2ca5764 (npm 3.5.2, MacOS) and here. Maybe it's OS specific? |
Keep in mind that this is most likely also affected by the user's machine specs. The diff might be notably higher on lower end computers. |
I'm running OSX 10.11.2 / MacBook Pro 2015 |
@AgronKabashi i'm sure the slowdown would still be rationally similar. Seems like regardless of how slow the system is, most are experiencing something around a 2x slowdown. |
What terminal app do you use and what font do you have selected? Also, do you have anti-aliasing enabled in your terminal? The system might be using a fallback font for rendering the progress bar, since most "nice" programming fonts don't have line glyphs that the progress bar uses. That could be slowing things down. Also, AA or other fancy graphical things (transparent windows) can slow down draw commands. I'd make sure your terminal is up to date or try a nightly build if it's iTerm. |
I'd be curious to see a performance measurement with non-ascii anti-aliasing disabled. I suspect this is slow draw performance. |
Here's my diff: progress=false
progress=true
I'm running Inconsolata-dz for Powerline with regular anti-aliasing and non-ascii anti-aliasing disabled. To maintain parity, here are the tests with Monaco 12pt with AA on for all fonts and a transparent window: progress=false
progress=true
Some difference, but not huge. I wonder if someone can run it with |
Regardless of progress bar.. |
For what it's worth, I seem to be affected by this as well: progress=false$ time npm install
...
real 1m30.147s
user 1m2.716s
sys 0m5.052s $ time npm install
...
real 1m17.472s
user 0m58.336s
sys 0m4.484s $ time npm install
...
real 1m20.335s
user 1m1.436s
sys 0m4.976s progress=true$ time npm install
...
real 2m35.531s
user 2m11.340s
sys 0m5.628s $ time npm install
...
real 2m23.303s
user 2m4.780s
sys 0m5.396s $ time npm install
...
real 2m21.438s
user 2m2.048s
sys 0m4.880s I'm on Ubuntu 15.04, GNOME Terminal 3.14.2, with the default font. |
npm appears to be working on it in https://github.com/iarna/gauge/issues/7 |
If my modest benchmarks can help in some way:
I'm using iTerm 2.1.4 with Droid Sans Mono font. |
TL;DRInstalling without the progress bar on npm causes a 20% speedup to overall install time. The slowdown is due to a hot method call that if throttled, would prevent the majority of the slowdown. Over the past few days or so, there have been some interesting comments on twitter around npm’s progress bar and the performance cost of having it enabled. Instead of just blindly throwing conclusions only based on running On a cold run with a prewarmed .npm cache folder from an earlier install, I am seeing a 20% increase in the install time .. from npm i to process exit. With ProgressWithout ProgressStepping down into the bottom up view of the cpu profiler in chrome devtools right away we can verify exactly what is eating up that 20% With tracker on:With tracker off:Hmm so when the progress bar is enabled it looks like 23~% of the program time is being spent in a method called Taking a look in Cachegrind via https://github.com/jlfwong/chrome2calltree allows us to even further visulize the sheer cost of the progress bar during runtime ^ That big red blob is time spent inside of the loggingSo there seems to be 3 players in progress bar game here: Gauge https://github.com/iarna/gauge/blob/master/progress-bar.js The question is what is causing so much time to be spent in the log methods. So then let’s look at Alright, so it looks like we are totally skipping it if progress has been disabled.. So let’s take one more step into the gauge show code: Well this seems to be the issue and the reason for the massive slowdown, although there is some throttling happening inside of the ProgressBar code, we are still calling into it a lot and doing quite a bit of work before we eager exit. By simplifying the logic in the method, removing the inline method definition (which is probably causing v8 to do some extra work due to scope variable binding) and upstreaming the throttling responsibility, I believe that the cost of showing the progress bar can be significantly cut down. |
Jumping into this conversation, (I'm "SomeKittens", not just "Kittens"). I tried a few different packages and got different results (though I was able to repro the timings with |
Just a quick note to say that the CLI team is aware of this issue, and after @samccone's in-depth analysis (for which: thank you very much), much further contribution to the thread is likely to just be piling on. |
Nice profiling tools! Noting them down 📝 |
@samccone That is some legit detective work. I 🙇 to you sir. |
Awesome analysis as usual @samccone. Thank you |
TBH I'm a bit embarrassed that I didn't push out a quick gauge patch earlier. I've been aware of this as an issue for a while and the fix was literally 10 minutes or so of effort, but it hadn't bubbled up in priority as I hadn't realized how big an impact it was having. I'd been waiting as it's addressed by the improved architecture of the rewrite (prints at a set interval, no debounce needed), but clearly it was worth doing sooner than later. |
@iarna no need to be embarrassed. This only surfaced due to its immense popularity ✌️ |
This should speed up npm install. See npm/npm#11283
This should speed up npm install. See npm/npm#11283
This should speed up npm install. See npm/npm#11283
Is it possible to set |
@kevinSuttle You can put |
I'm closing this because we landed the updated gauge ages in v3.10.0, way back in June, and there shouldn't be any more progress bar related slow downs. (It prints at a fixed interval now, so printing it shouldn't be adding a measurable amount of work.) |
Compare these runtimes of
npm install
:Npm 3.5.2. Both commands were run with already warmed-up cache. Progress bar may be responsible for up to 50% slow down.
Original source: https://twitter.com/gavinjoyce/status/691783314261331969 by @GavinJoyce
The text was updated successfully, but these errors were encountered: