Skip to content
This repository was archived by the owner on Aug 11, 2022. It is now read-only.

inflate-shrinkwrap: allow fakeChildren for non-integrity types #20029

Closed
wants to merge 1 commit into from
Closed

inflate-shrinkwrap: allow fakeChildren for non-integrity types #20029

wants to merge 1 commit into from

Conversation

zkat
Copy link
Contributor

@zkat zkat commented Mar 12, 2018

@zkat zkat requested a review from a team as a code owner March 12, 2018 21:16
@jmorrell
Copy link

Oh yay! Thank you for taking a look at this :)

@zkat
Copy link
Contributor Author

zkat commented Mar 12, 2018

@jmorrell thanks so much for the excellent repro. It was really easy to figure out what was going on (and whether I'd fixed it) because I was able to check what exactly you were running into, in context. Seriously, thanks ^_^

@iarna
Copy link
Contributor

iarna commented Mar 12, 2018

Looks good—we definitely should be constructing fake children for any entry that matches what we produce, at the very least.

@zkat
Copy link
Contributor Author

zkat commented Mar 12, 2018

Note: I'm gonna hold off on merging this. It's making some of our tests fail (probably because they weren't written expecting to take the fakeChild code path), so it'll have to go in next release.

@iarna iarna force-pushed the release-next branch 3 times, most recently from bcc4670 to 4a65b3b Compare March 23, 2018 21:22
@zkat zkat force-pushed the zkat/fake-child-metadata branch from 3e757db to afcdecd Compare April 5, 2018 22:08
@zkat zkat force-pushed the zkat/fake-child-metadata branch from afcdecd to 7e971af Compare April 5, 2018 22:23
iarna pushed a commit that referenced this pull request Apr 9, 2018
@zkat @iarna
inflate-shrinkwrap: allow fakeChildren for non-integrity types
5c7f543 
Credit: @zkat
PR-URL: #20029
Reviewed-By: @iarna
iarna pushed a commit that referenced this pull request Apr 10, 2018
@zkat @iarna
inflate-shrinkwrap: allow fakeChildren for non-integrity types
d141b69 
Credit: @zkat
PR-URL: #20029
Reviewed-By: @iarna
iarna pushed a commit that referenced this pull request Apr 10, 2018
@zkat @iarna
inflate-shrinkwrap: allow fakeChildren for non-integrity types
d387da3 
Credit: @zkat
PR-URL: #20029
Reviewed-By: @iarna
iarna pushed a commit that referenced this pull request Apr 11, 2018
@zkat @iarna
inflate-shrinkwrap: allow fakeChildren for non-integrity types
429498a 
Credit: @zkat
PR-URL: #20029
Reviewed-By: @iarna
iarna pushed a commit that referenced this pull request Apr 11, 2018
@zkat @iarna
inflate-shrinkwrap: allow fakeChildren for non-integrity types
db846c2 
Credit: @zkat
PR-URL: #20029
Reviewed-By: @iarna
@iarna iarna force-pushed the release-next branch 3 times, most recently from 2e76172 to fe31e66 Compare April 13, 2018 20:20
@iarna iarna force-pushed the release-next branch 2 times, most recently from 63c9452 to 1b021d0 Compare April 21, 2018 00:09
@iarna
Copy link
Contributor

iarna commented May 3, 2018

Landed in 6.0.0!

@iarna iarna closed this May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iarna iarna iarna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zkat @jmorrell @iarna