Skip to content
This repository was archived by the owner on Aug 11, 2022. It is now read-only.

error-message: Fix messaging for 401 errors that lack a reason #20032

Closed
wants to merge 1 commit into from

Conversation

iarna
Copy link
Contributor

@iarna iarna commented Mar 13, 2018

Prevously they were falling through to 404 handling and being printed as:

npm ERR! 404 Registry returned 401 for DELETE on …

Prevously they were falling through to 404 handling and being printed as:

npm ERR! 404 Registry returned 401 for DELETE on …
@iarna iarna requested a review from a team as a code owner March 13, 2018 01:33
Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑

@iarna iarna force-pushed the release-next branch 3 times, most recently from bcc4670 to 4a65b3b Compare March 23, 2018 21:22
iarna added a commit that referenced this pull request Apr 10, 2018
Prevously they were falling through to 404 handling and being printed as:

npm ERR! 404 Registry returned 401 for DELETE on …

Credit: @iarna
Reviewed-By: @zkat
PR-URL: #20032
iarna added a commit that referenced this pull request Apr 10, 2018
Prevously they were falling through to 404 handling and being printed as:

npm ERR! 404 Registry returned 401 for DELETE on …

Credit: @iarna
Reviewed-By: @zkat
PR-URL: #20032
iarna added a commit that referenced this pull request Apr 10, 2018
Prevously they were falling through to 404 handling and being printed as:

npm ERR! 404 Registry returned 401 for DELETE on …

Credit: @iarna
Reviewed-By: @zkat
PR-URL: #20032
iarna added a commit that referenced this pull request Apr 11, 2018
Prevously they were falling through to 404 handling and being printed as:

npm ERR! 404 Registry returned 401 for DELETE on …

Credit: @iarna
Reviewed-By: @zkat
PR-URL: #20032
iarna added a commit that referenced this pull request Apr 11, 2018
Prevously they were falling through to 404 handling and being printed as:

npm ERR! 404 Registry returned 401 for DELETE on …

Credit: @iarna
Reviewed-By: @zkat
PR-URL: #20032
iarna added a commit that referenced this pull request Apr 11, 2018
Prevously they were falling through to 404 handling and being printed as:

npm ERR! 404 Registry returned 401 for DELETE on …

Credit: @iarna
Reviewed-By: @zkat
PR-URL: #20032
@iarna iarna force-pushed the release-next branch 3 times, most recently from 2e76172 to fe31e66 Compare April 13, 2018 20:20
@iarna iarna force-pushed the release-next branch 2 times, most recently from 63c9452 to 1b021d0 Compare April 21, 2018 00:09
@iarna
Copy link
Contributor Author

iarna commented May 3, 2018

This shipped in 6.0.0

@iarna iarna closed this May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants