This repository was archived by the owner on Aug 11, 2022. It is now read-only.

cli: shinier update-notifier #20122

Closed

zkat wants to merge 1 commit into release-next from zkat/shiny-notifier

Contributor

zkat commented Mar 21, 2018

This message is based on the one pnpm uses, which
I think takes care of all the false update messages and
missing -g that happens with the default notifier message.

Preview:

I did 4 things:

Moved the update check to post-npm.load() so we have access to config. I think this is fine -- if your npm isn't even loading, you can't even update, so.
Added a colorful message about what "level" the update is (major/minor/patch)
Added a link to the changelog right in the message
Forced a -g in the message because update-notifier's detection of globals keeps messing up and if people have npm installed locally, they probably know well enough that they need to omit the -g -- vs folks getting confused because the -g is missing.

Cheers to @zkochan for the corresponding version of this in pnpm, which I think is way better than the default, and I hope he's ok with us cribbing it like this. 💚

zkat requested a review from a team as a code owner

March 21, 2018 12:22

iarna force-pushed the release-next branch 3 times, most recently from bcc4670 to 4a65b3b Compare

March 23, 2018 21:22

zkat force-pushed the release-next branch from 748c06e to ada9c6c Compare

April 4, 2018 00:58

zkat force-pushed the zkat/shiny-notifier branch 3 times, most recently from 719cb2e to 001fd3d Compare

April 5, 2018 17:29


          cli: shinier update-notifier

4205b5c

This message is based on the one pnpm uses, which
I think takes care of all the false update messages and
missing -g that happens with the default notifier message.

It also tells people what "level" the update is.

zkat force-pushed the zkat/shiny-notifier branch from 001fd3d to 4205b5c Compare

April 5, 2018 20:46

iarna approved these changes

View reviewed changes

iarna pushed a commit that referenced this pull request


          cli: shinier update-notifier

020efb6

This message is based on the one pnpm uses, which
I think takes care of all the false update messages and
missing -g that happens with the default notifier message.

It also tells people what "level" the update is.

Credit: @zkat
PR-URL: #20122
Reviewed-By: @iarna

iarna pushed a commit that referenced this pull request


          cli: shinier update-notifier

d803163

This message is based on the one pnpm uses, which
I think takes care of all the false update messages and
missing -g that happens with the default notifier message.

It also tells people what "level" the update is.

Credit: @zkat
PR-URL: #20122
Reviewed-By: @iarna

iarna pushed a commit that referenced this pull request


          cli: shinier update-notifier

c74faba

This message is based on the one pnpm uses, which
I think takes care of all the false update messages and
missing -g that happens with the default notifier message.

It also tells people what "level" the update is.

Credit: @zkat
PR-URL: #20122
Reviewed-By: @iarna

iarna force-pushed the release-next branch from 1a78f57 to 2a71d18 Compare

April 10, 2018 01:50

iarna pushed a commit that referenced this pull request


          cli: shinier update-notifier

57e0980

This message is based on the one pnpm uses, which
I think takes care of all the false update messages and
missing -g that happens with the default notifier message.

It also tells people what "level" the update is.

Credit: @zkat
PR-URL: #20122
Reviewed-By: @iarna

iarna force-pushed the release-next branch from 2a71d18 to d2d290b Compare

April 11, 2018 01:25

iarna pushed a commit that referenced this pull request


          cli: shinier update-notifier

834b46f

This message is based on the one pnpm uses, which
I think takes care of all the false update messages and
missing -g that happens with the default notifier message.

It also tells people what "level" the update is.

Credit: @zkat
PR-URL: #20122
Reviewed-By: @iarna

iarna pushed a commit that referenced this pull request


          cli: shinier update-notifier

3e12d24

This message is based on the one pnpm uses, which
I think takes care of all the false update messages and
missing -g that happens with the default notifier message.

It also tells people what "level" the update is.

Credit: @zkat
PR-URL: #20122
Reviewed-By: @iarna

iarna force-pushed the release-next branch 3 times, most recently from 2e76172 to fe31e66 Compare

April 13, 2018 20:20

iarna force-pushed the release-next branch 2 times, most recently from 63c9452 to 1b021d0 Compare

April 21, 2018 00:09

Contributor

iarna commented May 3, 2018

Landed in 6.0.0!

iarna closed this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet