feat(repo): replace explicit matrix with dynamic parsed from json #30120
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit 32a68a2.
☁️ Nx Cloud last updated this comment at |
0c508cc to
13bf1a9
Compare
| @@ -0,0 +1,41 @@ | |||
| { | |||
| "coreProjects": [ | |||
There was a problem hiding this comment.
Does jq allow for comments in JSON? Can we annotate what these things mean?
Actually, can we skip jq and just parse it out in JS instead? And can we also have that as a ts file that we run via like tsx prepare-matrix.ts?
There was a problem hiding this comment.
The jq does not support jsonc format.
We can load and parse it within script, yes.
We can wrap entire logic within prepare-matrix.ts and execute it to retrieve matrix JSON. I wanted to avoid ts files to make things "closer to the metal" but I guess there is benefit on wrapping the entire logic away.
42cd7fc to
ae66fef
Compare
ae66fef to
3b48f29
Compare
3b48f29 to
c773fb7
Compare
Change has been implemented and has been blocked for almost a month
…0120) This PR replaces the cumbersome explicit matrix in `e2e-matrix.yml` with a dynamic matrix built from the input JSON data. ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit 30781f7)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This PR replaces the cumbersome explicit matrix in
e2e-matrix.ymlwith a dynamic matrix built from the input JSON data.Current Behavior
Expected Behavior
Related Issue(s)
Fixes #