Skip to content

fix(core): handle null outputs in native cache #30398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2025
Merged

fix(core): handle null outputs in native cache #30398

merged 1 commit into from
Mar 17, 2025

Conversation

AgentEnder
Copy link
Member

Current Behavior

cache.rs expects outputs to always be an array

Expected Behavior

cache.rs is able to handle null

Related Issue(s)

Fixes #

@AgentEnder AgentEnder requested review from a team as code owners March 17, 2025 16:32
@AgentEnder AgentEnder requested a review from Cammisuli March 17, 2025 16:32
@vercel Vercel
Copy link

vercel bot commented Mar 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Mar 17, 2025 4:34pm

@nx-cloud Nx Cloud
Copy link
Contributor

nx-cloud bot commented Mar 17, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit d72c68a.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 38m View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 15s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base=3a2c2... ✅ Succeeded 1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 1s View ↗
nx documentation ✅ Succeeded 3m 56s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-17 17:18:58 UTC

@AgentEnder AgentEnder enabled auto-merge (squash) March 17, 2025 16:49
@AgentEnder AgentEnder merged commit 46d55ad into master Mar 17, 2025
12 checks passed
@AgentEnder AgentEnder deleted the fix/nullable-outputs branch March 17, 2025 17:19
FrozenPandaz pushed a commit that referenced this pull request Mar 17, 2025
@AgentEnder @FrozenPandaz
fix(core): handle null outputs in native cache (#30398)
1c3ef85 
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
`cache.rs` expects outputs to always be an array

## Expected Behavior
`cache.rs` is able to handle null

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #

(cherry picked from commit 46d55ad)
@github-actions GitHub Actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@meeroslav meeroslav meeroslav approved these changes

@FrozenPandaz FrozenPandaz FrozenPandaz approved these changes

@Cammisuli Cammisuli Awaiting requested review from Cammisuli Cammisuli is a code owner automatically assigned from nrwl/nx-core-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AgentEnder @meeroslav @FrozenPandaz