fix: remove redundant checks and add explicit render mode #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove redundant type and length checks for turnstileSiteKey Environment variables are either undefined or string, so simple truthy check is sufficient - Add ?render=explicit to Turnstile script URL for better control over widget rendering 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
ghostpaste | ef89195 | Visit preview | Jun 08 2025, 05:53 PM |
- Replace setInterval polling with Cloudflare's official onload callback mechanism - Add onloadTurnstileCallback to Window interface - Update script URL to include onload parameter - Fix bug where cleanup function wasn't registered when Turnstile was pre-loaded - Update tests to properly simulate the callback flow - Better performance and cleaner implementation 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
typeof turnstileSiteKey === "string" && turnstileSiteKey.length > 0as environment variables are eitherundefinedor string values, making these checks redundant?render=explicitto the Turnstile script URL to ensure we have full control over when the widget rendersTest plan
🤖 Generated with Claude Code