Skip to content

perf: optimize Turnstile callbacks to prevent re-renders #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2025
Merged

perf: optimize Turnstile callbacks to prevent re-renders #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 33 additions & 29 deletions app/create/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,27 @@ export default function CreateGistPage() {
const [turnstileToken, setTurnstileToken] = useState<string | null>(null);
const [isTurnstileReady, setIsTurnstileReady] = useState(false);

// Stable callback references to prevent Turnstile re-renders
const handleTurnstileSuccess = useCallback((token: string) => {
setTurnstileToken(token);
setIsTurnstileReady(true);
}, []);

const handleTurnstileError = useCallback(() => {
setError(
"🛡️ Security check failed. Please refresh the page and try again."
);
setIsTurnstileReady(false);
}, []);

const handleTurnstileExpire = useCallback(() => {
setTurnstileToken(null);
setIsTurnstileReady(false);
setError(
"⏰ Security verification expired. Please refresh the page to continue."
);
}, []);

const handleFilesChange = useCallback((newFiles: FileData[]) => {
setFiles(newFiles);
// Don't clear errors on file change - let them persist
Expand Down Expand Up @@ -321,35 +342,6 @@ export default function CreateGistPage() {
</CardContent>
</Card>

{/* Invisible Turnstile Verification */}
{turnstileSiteKey && (
<div className="hidden">
<Turnstile
sitekey={turnstileSiteKey}
action="create_gist"
onSuccess={(token) => {
setTurnstileToken(token);
setIsTurnstileReady(true);
}}
onError={() => {
setError(
"🛡️ Security check failed. Please refresh the page and try again."
);
setIsTurnstileReady(false);
}}
onExpire={() => {
setTurnstileToken(null);
setIsTurnstileReady(false);
setError(
"⏰ Security verification expired. Please refresh the page to continue."
);
}}
theme="auto"
appearance="interaction-only"
/>
</div>
)}

{/* Error Display */}
{(error || validationMessage) && (
<Alert variant="destructive">
Expand Down Expand Up @@ -394,6 +386,18 @@ export default function CreateGistPage() {
)}
</div>

{/* Invisible Turnstile Verification */}
{turnstileSiteKey && (
<Turnstile
sitekey={turnstileSiteKey}
action="create_gist"
onSuccess={handleTurnstileSuccess}
onError={handleTurnstileError}
onExpire={handleTurnstileExpire}
appearance="interaction-only"
/>
)}

{/* Share Dialog */}
{shareUrl && (
<ShareDialog
Expand Down
2 changes: 2 additions & 0 deletions components/ui/turnstile.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ describe("Turnstile", () => {
const mockRender = vi.fn().mockReturnValue("widget-123");
const mockReset = vi.fn();
const mockRemove = vi.fn();
const mockExecute = vi.fn();
const mockOnSuccess = vi.fn();
const mockOnError = vi.fn();
const mockOnExpire = vi.fn();
Expand All @@ -16,6 +17,7 @@ describe("Turnstile", () => {
render: mockRender,
reset: mockReset,
remove: mockRemove,
execute: mockExecute,
};

vi.clearAllMocks();
Expand Down