Skip to content

refactor: expose CodeEditor handle #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2025
Merged

refactor: expose CodeEditor handle #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 30 additions & 4 deletions components/ui/code-editor.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ describe("CodeEditor", () => {
});
});

it("calls onChange when content is modified", async () => {
it("calls onChange on blur after content is modified", async () => {
const handleChange = vi.fn();
const user = userEvent.setup();

Expand All @@ -41,16 +41,22 @@ describe("CodeEditor", () => {
await user.click(editor);
await user.type(editor, "test");

// onChange shouldn't be called yet
expect(handleChange).not.toHaveBeenCalled();

// Blur the editor
await user.tab();

await waitFor(() => {
expect(handleChange).toHaveBeenCalled();
expect(handleChange).toHaveBeenCalledWith("test");
});
});

it("respects readOnly prop", async () => {
const handleChange = vi.fn();

render(
<CodeEditor value="readonly content" readOnly onChange={handleChange} />
<CodeEditor value="readonly content" readOnly onChange={handleChange} />,
);

await waitFor(() => {
Expand All @@ -73,7 +79,7 @@ describe("CodeEditor", () => {

it("applies custom className", () => {
const { container } = render(
<CodeEditor className="custom-editor-class" />
<CodeEditor className="custom-editor-class" />,
);

expect(container.firstChild).toHaveClass("custom-editor-class");
Expand Down Expand Up @@ -140,6 +146,26 @@ describe("CodeEditor", () => {
});
});

it("exposes an imperative API to get the current value", async () => {
const ref = { current: null } as React.MutableRefObject<any>;
const user = userEvent.setup();

render(<CodeEditor ref={ref} />);

await waitFor(() => {
const editor = document.querySelector(".cm-content");
expect(editor).toBeInTheDocument();
});

const editor = document.querySelector(".cm-content") as HTMLElement;
await user.click(editor);
await user.type(editor, "value");

await user.tab();

expect(ref.current?.getValue()).toBe("value");
});

it("renders loading state during SSR", () => {
// The component should render during SSR with loading state
const { container } = render(<CodeEditor />);
Expand Down
Loading