fix: refactor duplicate filename validation to parent component #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
ghostpaste | e5b0ac9 | Visit preview | Jun 07 2025, 02:42 AM |
## Summary - Move duplicate filename validation from FileEditor to MultiFileEditor - Update validation to show errors without blocking input (better UX) - Add onValidationChange callback for parent components - Update tests to reflect new validation behavior ## Changes - FileEditor now accepts an `error` prop for external validation errors - MultiFileEditor tracks duplicate filenames and passes errors down - Users can type freely while seeing validation errors in real-time - Form submission can be blocked at parent level based on validation state This provides a cleaner separation of concerns where MultiFileEditor owns the list of files and validates uniqueness, while FileEditor only handles local validation (empty names, invalid characters). 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
9eb7d38 to
230338e
Compare
- Simplify test assertions to be less brittle - Use fireEvent.change for reliable input simulation - Fix auto-detect language test to properly verify functionality - All tests now pass without warnings 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The current implementation validates duplicate filenames at the FileEditor level, which creates coupling issues since FileEditor needs to know about all other files. This also blocks user input when duplicates are detected, creating a poor user experience.
Solution
This PR refactors the validation logic:
errorprop for external validation messagesonValidationChangecallback to enable/disable form submissionChanges
errorprop for external validation errorsonValidationChangecallback to notify parent components of validation stateTest plan
🤖 Generated with Claude Code