Skip to content

feat: implement Container component for consistent spacing #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2025

Conversation

nullcoder
Copy link
Owner

Implement Container component as specified in issue #62 for consistent layout and spacing across the application.

Changes

  • Create Container component with 4 variants (default, narrow, wide, full)
  • Implement responsive padding scale:
    • Mobile: 16px padding
    • Tablet (768px+): 32px padding
    • Desktop (1024px+): 48px padding
  • Add prose typography support for text-heavy content
  • Support custom element types via 'as' prop for semantic HTML
  • Create comprehensive tests with 100% coverage
  • Add interactive demo page showcasing all features

Technical Details

  • Uses Tailwind CSS classes for all styling
  • Leverages cn() utility for class name composition
  • Follows existing component patterns in the codebase
  • Fully typed with TypeScript

Demo

The demo page at /demo/container showcases:

  • All container variants with visual examples
  • Responsive padding behavior
  • Prose typography styling
  • Nested container usage
  • Custom styling capabilities
  • Semantic HTML support

Closes #62

- Create Container component with 4 variants (default, narrow, wide, full)
- Implement responsive padding scale (16px mobile, 32px tablet, 48px desktop)
- Add prose typography support for text-heavy content
- Support custom element types via 'as' prop
- Create comprehensive tests with 100% coverage
- Add interactive demo page showcasing all features

The Container component provides consistent layout constraints and responsive
spacing across the application, following the design specifications.

Co-Authored-By: Claude <claude@ghostpaste.dev>
Copy link

cloudflare-workers-and-pages bot commented Jun 7, 2025

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
ghostpaste fc2f0ce Visit preview Jun 07 2025, 06:46 AM

@nullcoder nullcoder merged commit 62f9a0f into main Jun 7, 2025
1 check passed
@nullcoder nullcoder deleted the feat/container-component branch June 7, 2025 06:49
nullcoder added a commit that referenced this pull request Jun 7, 2025
- Mark Container component (#62) as complete in TODO.md
- Update PHASE_4_ISSUE_TRACKING.md status to complete
- Add Container PR #90 to completed PRs list
- Update progress summary: 12/19 issues complete (63%)
- Update next priority issues list
- Update last modified date to 2025-06-07

Co-Authored-By: Claude <claude@ghostpaste.dev>
nullcoder added a commit that referenced this pull request Jun 7, 2025
- Mark Container component (#62) as complete in TODO.md
- Update PHASE_4_ISSUE_TRACKING.md status to complete
- Add Container PR #90 to completed PRs list
- Update progress summary: 12/19 issues complete (63%)
- Update next priority issues list
- Update last modified date to 2025-06-07

Co-authored-by: Claude <claude@ghostpaste.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: create container component for consistent spacing
1 participant