Skip to content

np.set_printoptions(legacy=True) is not future proof #10020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eric-wieser opened this issue Nov 14, 2017 · 2 comments · Fixed by #10030
Closed

np.set_printoptions(legacy=True) is not future proof #10020

eric-wieser opened this issue Nov 14, 2017 · 2 comments · Fixed by #10030
Assignees
@ahaldane
Labels
15 - Discussion

Comments

@eric-wieser
Copy link
Member

It's possible we'll want to change the repr again in future, but this is hard to extend in a backwards compatiable way. Should we use legacy=(1,13) or legacy='1.13' instead?
@eric-wieser eric-wieser added this to the 1.14.0 release milestone Nov 14, 2017
@charris
Copy link
Member

charris commented Nov 15, 2017

Good point.

@ahaldane
Copy link
Member

Good idea, will do.

@ahaldane ahaldane mentioned this issue Nov 15, 2017
Merged
ahaldane added a commit to ahaldane/numpy that referenced this issue Nov 17, 2017
@ahaldane
MAINT: make legacy option support future legacy modes
dd31f13 
Fixes numpy#10020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahaldane ahaldane

Labels
15 - Discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MAINT: Legacy mode specified as string, fix all-zeros legacy bug ahaldane/numpy
3 participants
@charris @eric-wieser @ahaldane