-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
numpy.ma.tests.test_regression.TestRegression.test_var_sets_maskedarray_scalar is racy #10270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Since when did appveyor start listing the tests? |
It alarms me that
And |
I enabled that functionality. I hope you don't mind? |
I'm just curious how you did it |
It's possible this is the cause of numpygh-10270, where it seems something is wrong with the shape
@eric-wieser - I see why in #10308 you thought maybe to avoid this type of stuff with making the mask shape effectively unsettable. But looking at the code, the only shape that could possibly be relevant would seem to be the one on |
Ah, sorry, I see now: #10292 stopped from assigning attributes of |
From your comment there, I think you hit the nail on the head with
This looks very likely to be the cause, which of course #10308 will do nothing to prevent |
Misclick, sorry |
It's possible this is the cause of numpygh-10270, where it seems something is wrong with the shape
Turns out that |
And a simpler test-case: >>> np.array(np.ma.masked, subok=True, ndmin=2, copy=False)
>>> np.ma.masked.mask.ndim
2 |
I reproduce the bug with |
…mask This prevents consumers from reshaping the mask in place, which breaks things As a result, `x.mask is x.mask` returns `False`, but this was already true of `x.data is x.data`. May also be related to numpygh-10270
This test has failed a few times with the following message:
And stack trace
Link to failures: https://ci.appveyor.com/project/charris/numpy/build/1.0.8371/job/ewtkpj7ss3beoky3/tests
The text was updated successfully, but these errors were encountered: