-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
np.random.bit_generator broken at 1.18 #15152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It is not a deprecation, it is a code change. You need to update your code. We probably should have mentioned it in the release notes. |
This was done in gh-14608. The release note update would have been useful, we should probably still amend this since release notes get read for a long time. We don't often update those, but in this case it seems justified. |
I thought the point of depreciation was to not immediately break modules when there was a code change. They don't seem mutually exclusive. I also thought it was good package management practice in high profile projects that if a user upgrades one release to the next that nothing breaks immediately without depreciation warnings When np.random.random_integers changed to np.random.randint random_integers spammed depreciation warnings until this day. That was useful because code still ran and I could migrate over as I touched code. It is true that random_integer to randint changed the argument interpretation, so it was not just _"a code change", apparently, but the larger and more important thing to me actually using the interface, is you didn't just delete np.random.random_integer. You could have! But you didn't and I thank you for it! |
Sometimes, we make mistakes. We should have more clearly signposted in the 1.17 release that we expected some mistakes of this nature given the size of this new subsystem and that we would simply fix them without a long deprecation period. We apologize for the inconvenience. |
Hello, at the time of using pandas-profiling it is showing me the error
Please help!! |
I don't see any code in |
Thanks for the help the problem is solved! |
See also: numpy/numpy#15152 Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
Reproducing code example:
Numpy/Python version information:
numpy==1.18
work fine at numpy==1.17.4, I have read release log,
at 1.17,
bit_generator
is not at deprecation?I have read numpy code at 1.18,this module move to
np.random._bit_generator
,cause this brokenThe text was updated successfully, but these errors were encountered: