-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Discussion: Move numpy.array_api
elsewhere?
#22252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
To clarify for others what (in my opinion) the state is:
With respect to CuPy, the second namespace is interesting. Whatever we do for NumPy (or CuPy) should translate almost 1:1 to the other, but I suspect a change like replacing |
I think we can indeed discuss moving the current
@leofang where do you think it should live? And do you think the overhead will go down in total, given that there's now a separate package to maintain? Also, if that exists standalone, will you still vendor it into CuPy or declare a dependency on it?
This is related to gh-21135 and to data-apis/array-api#400. There's a lot more detail there, so I suggest to keep this issue about the current, strictly compliant-only version of |
I do not think that is necessary. CuPy should not need such an implementation since the purpose of this package will be to test that a library does not require API beyond the minimal array-API implementation (should generalize to all implementors).
Right, these are indeed annoying. OTOH, you will not be locked into the NumPy release cycle. Since this package is most interesting for testing/CI, maybe that is the bigger advantage? I.e. it is OK if tests are not run always. Tests might use a switches like: |
I think that the reason @leofang brought this up is to keep the CuPy and NumPy version of the current, largely duplicated, code in sync. If the answer is now: "let |
it has moved! |
As discussed in recent Python array API standard meetings, @seberg and others raised the question about the future of
numpy.array_api
. One of the reasons is that being under a namespace does not make it very useful. It was suggested that it can be made as a standalone package, for which the CuPy team is interested in making it supportcupy.ndarray
too to avoid code duplication. Opening this issue to gather additional feedbacks and discuss technical issues.cc: @kmaehashi @rgommers
The text was updated successfully, but these errors were encountered: