-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Handle warning about private API and pybind11 before 2.0.0rc1 #26010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I am not sure I can agree that silencing the warning is an option. Remember that without the fixes at least in some parts, SciPy would have just returned incorrect results. |
We are about ready for 2.0.0rc1. |
This issue is blocking, it needs to be resolved first on the |
Is there a tracking issue we can follow to see the progress? |
I assume @rgommers was talking about pybind/pybind11#5050 |
One team member has said they would review, and we are waiting on that review. Hopefully very soon. |
pybind11 2.12 is out! |
Awesome, thanks a lot @henryiii! |
In 2.0.0b1 we still have a very verbose and scary-looking warning like this:
Full warning:
We need to finalize this before
2.0.0rc1
in one of two ways:At #25918 (comment) we discussed a bit. @seberg said:
"That huge warning is seems only semi-useful, it would be nice to make it a hard error by the time we release, otherwise we don't protect users from potentially bad results/crashes due to a module that wasn't recompiled. I don't care much about
rc1
specifically it just seems like a plausible/reasonable warning shot for pybind11."I said: "Well, it must be done either before
rc1
or not at all. The way it looks now, it actually seems fairly safe to disable the warning, leaving the compat shim in place for 2.0, and make it a hard error onmain
in a month or so. Probably best to wait and see how apybind11
release is coming along, and decide in a week or so?"The outcome will depend on pybind/pybind11#5009. If
pybind11
manages to get a release out soon enough, we may be able to turn the warning into an error. If not, then it'll be too disruptive to do so.The text was updated successfully, but these errors were encountered: