Skip to content

return mutiple field selection as ro view #3641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
charris opened this issue Aug 20, 2013 · 6 comments
Closed

return mutiple field selection as ro view #3641

charris opened this issue Aug 20, 2013 · 6 comments

Comments

@charris
Copy link
Member

charris commented Aug 20, 2013

This transition is scheduled for 1.9

@charris charris added the Task label Feb 23, 2014
@charris
Copy link
Member Author

charris commented Apr 21, 2014

This is a bit tricky, the views are not the same as the copies due to alignment fields. That breaks some tests.

@charris
Copy link
Member Author

charris commented May 5, 2014

Going to move this to 1.10. The change is subtle and I don't want to deal with it for 1.9.

@charris
Copy link
Member Author

charris commented Jun 19, 2015

Bumping this again to 1.11.

@charris charris modified the milestones: 1.11.0 release, 1.10 blockers Jun 19, 2015
@charris
Copy link
Member Author

charris commented Jan 21, 2016

@ahaldane Should this be closed? What is the status? I'm tempted to close this and not make the attempt.

@charris charris modified the milestones: 1.12.0 release, 1.11.0 release Jan 21, 2016
@ahaldane
Copy link
Member

I would like it to be fixed at some point! #6053 already implements a possible fix, where I actually make multiple-field selection return a writeable view.

I don't think #6053 can be done for 1.11, but maybe 1.12. It needs some discussion since it introduces a behavior change. I think based on the confusion that periodically pops up related to field access and assignment which #6053 would resolve, there is a fair case in favor of the change.

#6053 needs a rebase, which I have sitting on my compute at home. I am just finishing up a project at work and hopefully will have more time for numpy soon.

@charris
Copy link
Member Author

charris commented Jan 21, 2016

It's been tagged for 1.12, so we can deal with it over the next 3-4 months.

ahaldane added a commit to ahaldane/numpy that referenced this issue Jun 17, 2016
This commit attempts to make structure assignment more consistent, and
then changes multi-field indices to return a view instead of a copy.

Assignment between structures now works "by field position" rather than
"by field name".

Fixes numpy#2353, fixes numpy#6085, fixes numpy#3351, fixes numpy#6085, fixes numpy#6314,
fixes numpy#2346, fixes numpy#7058, fixes numpy#3641, fixes numpy#5994, fixes numpy#7262,
fixes numpy#7493
@rgommers rgommers modified the milestone: 1.12.0 release Feb 15, 2017
@charris charris closed this as completed in 7412b85 Sep 9, 2017
theodoregoetz pushed a commit to theodoregoetz/numpy that referenced this issue Oct 23, 2017
This commit attempts to make structure assignment more consistent, and
then changes multi-field indices to return a view instead of a copy.

Assignment between structures now works "by field position" rather than
"by field name".

Fixes numpy#2353, fixes numpy#6085, fixes numpy#3351, fixes numpy#6085, fixes numpy#6314,
fixes numpy#2346, fixes numpy#7058, fixes numpy#3641, fixes numpy#5994, fixes numpy#7262,
fixes numpy#7493
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants