-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
return mutiple field selection as ro view #3641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is a bit tricky, the views are not the same as the copies due to alignment fields. That breaks some tests. |
Going to move this to 1.10. The change is subtle and I don't want to deal with it for 1.9. |
Bumping this again to 1.11. |
@ahaldane Should this be closed? What is the status? I'm tempted to close this and not make the attempt. |
I would like it to be fixed at some point! #6053 already implements a possible fix, where I actually make multiple-field selection return a writeable view. I don't think #6053 can be done for 1.11, but maybe 1.12. It needs some discussion since it introduces a behavior change. I think based on the confusion that periodically pops up related to field access and assignment which #6053 would resolve, there is a fair case in favor of the change. #6053 needs a rebase, which I have sitting on my compute at home. I am just finishing up a project at work and hopefully will have more time for numpy soon. |
It's been tagged for 1.12, so we can deal with it over the next 3-4 months. |
This commit attempts to make structure assignment more consistent, and then changes multi-field indices to return a view instead of a copy. Assignment between structures now works "by field position" rather than "by field name". Fixes numpy#2353, fixes numpy#6085, fixes numpy#3351, fixes numpy#6085, fixes numpy#6314, fixes numpy#2346, fixes numpy#7058, fixes numpy#3641, fixes numpy#5994, fixes numpy#7262, fixes numpy#7493
This commit attempts to make structure assignment more consistent, and then changes multi-field indices to return a view instead of a copy. Assignment between structures now works "by field position" rather than "by field name". Fixes numpy#2353, fixes numpy#6085, fixes numpy#3351, fixes numpy#6085, fixes numpy#6314, fixes numpy#2346, fixes numpy#7058, fixes numpy#3641, fixes numpy#5994, fixes numpy#7262, fixes numpy#7493
This transition is scheduled for 1.9
The text was updated successfully, but these errors were encountered: