Skip to content

document the change to .base semantics introduced by Add maskna= and ownmaskna= parameters to np.asarray and friends (6c0ad59) #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
certik opened this issue Sep 12, 2012 · 7 comments
Closed

document the change to .base semantics introduced by Add maskna= and ownmaskna= parameters to np.asarray and friends (6c0ad59) #438

certik opened this issue Sep 12, 2012 · 7 comments
Labels
Priority: high High priority, also add milestones for urgent issues
Milestone
NumPy 1.7

Comments

@certik
Copy link
Contributor

certik commented Sep 12, 2012

Per comment:

6c0ad59#commitcomment-1819948

this change should be documented and added into the release notes.
@certik certik mentioned this issue Sep 12, 2012
Closed
@njsmith
Copy link
Member

njsmith commented Sep 12, 2012

Those parameters were removed again in #297, so there's nothing to document...

@njsmith njsmith closed this as completed Sep 12, 2012
@njsmith
Copy link
Member

njsmith commented Sep 12, 2012

Oh, you mean, document the change in the .base parameter that was also included in that commit... sorry.

@njsmith njsmith reopened this Sep 12, 2012
@embray
Copy link
Contributor

embray commented Sep 12, 2012

Right...I don't fully understand what the maskna and ownmaskna parameters are, or how they were meant to be used. But their implementation also included changes to .base, which I'm guessing were necessary anyways. And I remember seeing some mailing list discussions about changing .base to only include arrays that own their data (a change a welcome, which makes walking .base a lot easier and closes some reference cycles that I've had to fight with in my own code).

But it's sort of unrelated to the original change that it rode in on.

@teoliphant
Copy link
Member

This is related to issue #470 so I'm closing this one.

@teoliphant teoliphant mentioned this issue Nov 6, 2012
Merged
@certik certik mentioned this issue Nov 14, 2012
Merged
@certik
Copy link
Contributor Author

certik commented Nov 14, 2012

I've added a note about .base into the release notes in PR #2737. Let me know if you think it is sufficient.

@embray
Copy link
Contributor

embray commented Nov 14, 2012

Works for me.

@embray embray mentioned this issue Dec 4, 2012
Merged
certik added a commit to certik/numpy that referenced this issue Dec 26, 2012
@certik
DOC: document the change in .base
a757cb5 
Fixes numpygh-438. Based on Nathan's comments in numpygh-2737.
@certik
Copy link
Contributor Author

certik commented Dec 27, 2012

This is now fixed by #2737.

@certik certik closed this as completed Dec 27, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: high High priority, also add milestones for urgent issues
Projects
None yet
Milestone
NumPy 1.7
Development

No branches or pull requests
4 participants
@certik @teoliphant @njsmith @embray