MAINT: Backcompat fixes for dragon4 changes #10008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
Nov 12, 2017
doc/release/1.14.0-notes.rst
Outdated
| @@ -403,6 +403,10 @@ elements uniquely. | |||
| Numpy complex-floating-scalars with values like ``inf*j`` or ``nan*j`` now | |||
| print as ``infj`` and ``nanj``, like the pure-python ``complex`` type. | |||
|
|
|||
| The ``FloatFormat`` and ``LongFloatFormat`` classes are deprecated and should | |||
| both be replaced by ``FloatingFormat``, and similarly ``ComplexFormat`` and | |||
There was a problem hiding this comment.
Nit: might be easier to read as ... . Similarly ...
eric-wieser
reviewed
Nov 12, 2017
numpy/core/arrayprint.py
Outdated
| class LongFloatFormat(FloatingFormat): | ||
| def __init__(self, *args, **kwargs): | ||
| warnings.warn("LongFloatFormat has been replaced by FloatingFormat", | ||
| DeprecationWarning, stacklevel=1) |
There was a problem hiding this comment.
Should this be stacklevel=2? I think we do that elsewhere.
|
There's something that sets EDIT: Looks like |
00ba158 to
d7f71c6
Compare
|
Thanks, fixed stacklevel and release note. |
|
Comment about the |
d7f71c6 to
a943f58
Compare
|
OOps, forgot that. Fixed now. |
eric-wieser
approved these changes
Nov 13, 2017
numpy/core/arrayprint.py
Outdated
| @@ -996,6 +1020,22 @@ def __call__(self, x): | |||
| i = self.imag_format(x.imag) | |||
| return r + i + 'j' | |||
|
|
|||
| # for back-compatibility, we keep the classes for each float type too | |||
[ci-skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small fixup to the dragon4 changes as suggested by @eric-wieser in #9941. This adds back in the
FloatFormatclasses that I deleted, but deprecates them.We can also discuss renaming
floatmodetofloat_mode. I didn't do that because, while it is true that some functions here use underscores, others don't. Eg, we already uselinewidthandedgeitemsin the_format_optionsdict and as args toset_printoptions. So I'd arguefloatmodeis the more consistent choice.It's a little strange we only allow
longdoubleto be separately customizable as aformatter, and not any of the other float types, but I guess that's the way it is, no real harm in leaving it so.