BUG: Fix assert_equal on time-like objects #10096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also does some cleanup on the float assert_equal to make it look more similar. Fixes numpy#10081
eric-wieser
commented
Nov 27, 2017
| # If one of desired/actual is not finite, handle it specially here: | ||
| # check that both are nan if any is a nan, and test for equality | ||
| # otherwise | ||
| if not (gisfinite(desired) and gisfinite(actual)): |
There was a problem hiding this comment.
I don't think there was any reason to special-case the infinite cases - those work fine under normal ==
4c123e5 to
f107d38
Compare
|
Test failures are garbage, and look like a pretty serious design flaw in travis/appveyor - if you push to the branch while it's running tests, it merges a different commit for each subjob, rather than resolving the branch head and using the same commit SHA1 in each one... |
1 task
|
LGTM, thanks Eric. |
|
Backport in #10103. Not quite straightforward as the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also does some cleanup on the float assert_equal to make it look more similar.
Fixes #10081, which was a regression in 1.13