ENH: Strip trailing spaces from continuation in multiline arrayprint #10129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f0a3409 to
a87b45c
Compare
This is otherwise pretty strict about trailing spaces, so we may as well cut them here too, especially since the repr has changed here already. The newlines look better to me for multi-dimensional arrays too.
a87b45c to
6df0b6e
Compare
|
I'll also merge this, since I think it is "obviously good". |
This was referenced Nov 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is otherwise pretty strict about trailing spaces, so we may as well cut them here too, especially since the repr has changed here already
Extracted from #10123, and with tests added - it turns out that we never tested this code path.
Milestoned for 1.14 since it's a formatting change