Header cleanup #102
Closed
Header cleanup #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This one handles PyArray_DEFAULT -> NPY_DEFAULT_TYPE and the NPY_* array flags -> NPY_ARRAY_*. The PyArray_DEFAULT vs NPY_DEFAULT confusion was particularly egregious here.
|
Thanks for splitting this out for me. It's only a start, but hopefully this provides a good mechanism for deprecating and improving the C API. |
|
I was leaving it up to you if it should be pushed as it may cause problems with the "where" thingie. If you give the OK I'll go ahead and apply it. |
|
I think rebasing my branch will go ok, feel free to apply it. |
|
Done. |
luyahan
pushed a commit
to plctlab/numpy
that referenced
this pull request
Apr 25, 2024
test: Add one more test case pointer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks out the header cleanup in pull request 99. There are still a few files that need to be checked/fixed, _dotblas.c, etc, but this does most of them.