BUG: duplicate message print if warning raises an exception #10257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you want to backport this, then it would be easiest if you rebase on 1368cbb And you missed the |
eric-wieser
reviewed
Dec 22, 2017
| @@ -475,22 +475,10 @@ array_dealloc(PyArrayObject *self) | |||
| "called."; | |||
| /* 2017-Nov-10 1.14 */ | |||
| if (DEPRECATE(msg) < 0) { | |||
| /* dealloc must not raise an error, best effort try to write | |||
| /* dealloc cannot raise an error, best effort try to write | |||
| to stderr and clear the error | |||
There was a problem hiding this comment.
I think you might need to actually clear the error before calling PyArray_ResolveWritebackIfCopy, in case the array is an object dtype, and PyArray_ResolveWritebackIfCopy causes refcounts to drop to zero which can run arbitrary python code
There was a problem hiding this comment.
Although I suppose that's an unrelated fix
There was a problem hiding this comment.
In the implementation of PyErr_WriteUnraisable it calls PyErr_Fetch which clears the error state
|
hopefully rebased correctly, off the first fix to PR #9639 |
eric-wieser
approved these changes
Dec 25, 2017
|
Thanks @mattip. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the discussion here
PyErr_WriteUnraisable(obj)first prints the error context fromPyErr_Fetch(which already prints the message) and then printsrepr(obj). The old code thus printed the message twice. This PR prints once then, for lack of a better context, shows that the problem originated in an ndarray.If not too late perhaps this should be backported to 1.14