MAINT: Adjust type promotion in linalg.norm #10368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added the |
|
But the failures of course suggest there is a problem... |
|
Failures are caused by #10374 |
b61ec46 to
bdf226c
Compare
mhvk
reviewed
Jan 11, 2018
numpy/linalg/linalg.py
Outdated
| @@ -24,7 +24,7 @@ | |||
| add, multiply, sqrt, maximum, fastCopyAndTranspose, sum, isfinite, size, | |||
| finfo, errstate, geterrobj, longdouble, moveaxis, amin, amax, product, abs, | |||
| broadcast, atleast_2d, intp, asanyarray, object_, ones, matmul, | |||
| swapaxes, divide, count_nonzero | |||
| swapaxes, divide, count_nonzero, reciprocal | |||
There was a problem hiding this comment.
Don't need reciprocal any more...
|
Apart from the nitpick, would seem ready to go in. |
…r speed Fixes numpygh-10364, partly by adjusting the promise in the release notes
|
Updated with the nit fix |
bdf226c to
04896b0
Compare
|
OK, will merge now. |
|
Needs a forward port, which can be done through the GitHub UI alone |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #10364.
Unfortunately the failing case there still doesn't work when the result is a scalar, due to falling afoul of #10322. We fix this by just not making any promise about the scalar case.
That seems pretty reasonable to me, since numpy makes it very hard to keep float32 scalars around anyway.