Skip to content

MAINT: Use ValueError for duplicate field names in lookup #10430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2018
Merged

MAINT: Use ValueError for duplicate field names in lookup #10430

merged 1 commit into from
Jan 18, 2018

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Jan 18, 2018 •
edited
Loading

KeyError suggests the field name does not exist, which is inaccurate.

This is a new error as of 1.14, so I think we can change its type without needing to consider back-compat.

Backportable here

@eric-wieser eric-wieser added this to the 1.14.1 release milestone Jan 18, 2018
@eric-wieser eric-wieser requested a review from ahaldane January 18, 2018 09:22
@eric-wieser eric-wieser mentioned this pull request Jan 18, 2018
Merged
@eric-wieser
Copy link
Member Author

Actually, this is a backcompat fix: On 1.13, this gave:

ValueError: name already used as a name or title

@eric-wieser
MAINT: Use ValueError for duplicate field names in lookup
47c4f32 
KeyError suggests the field name does not exist, which is inaccurate.
@eric-wieser eric-wieser force-pushed the duplicate-field-name-error branch from 66434d9 to 47c4f32 Compare January 18, 2018 09:41
mhvk
mhvk approved these changes Jan 18, 2018
View reviewed changes
Copy link
Contributor

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will merge.

@mhvk mhvk merged commit 1062cb2 into numpy:master Jan 18, 2018
@eric-wieser eric-wieser mentioned this pull request Jan 18, 2018
Merged
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Jan 18, 2018
@charris charris removed this from the 1.14.1 release milestone Jan 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhvk mhvk mhvk approved these changes

@ahaldane ahaldane Awaiting requested review from ahaldane

Assignees
No one assigned
Labels
03 - Maintenance 06 - Regression component: numpy._core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eric-wieser @mhvk @charris