BUG: multifield-indexing adds padding bytes: revert for 1.14.1 #10537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charris
reviewed
Feb 7, 2018
numpy/core/src/multiarray/mapping.c
Outdated
| _multifield_view_to_copy(PyArrayObject **view) { | ||
| static PyObject *copyfunc = NULL; | ||
| PyObject *viewcopy; | ||
| PyObject *mf_setting = NULL; |
There was a problem hiding this comment.
Seems this variable is no longer used, leading to test errors.
18d08ca to
ab349d7
Compare
Fixes numpy#10387 Fixes numpy#10344 Fixes numpy#10409
ab349d7 to
08469bb
Compare
|
Thanks Allan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10387
Fixes #10344
Fixes #10409
This is a version of #10411 targeting the 1.14.x maintenance branch. It reverts the copy->view change from 1.14.0, aiming to get into 1.14.1.