WIP: Move dtype.__repr__ and __str__ to python #10594
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing proper error checking of string concatenation in python super tedious. As a results, we're not doing it, making us prone to exceptions turning into segfaults. This moves all of the __str__ and __repr__ functions, where speed is irrelevant, into np.core._dtype.
5f94bdf to
b5ae289
Compare
If `repr` throws this would previously segfault
b5ae289 to
17bac32
Compare
|
Mystery resolved, moved to #10602 which has a better branch name |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fails on my machine, hoping for better diagnostics from travis