np.array constructor can convert PyDateTime to np.datetime64 #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly disabled using NPY_ARRAY_CONVERT_DATETIME macro.
|
@m-paradox Mark, how is this looking? |
|
Sorry, Mark had some good criticisms of the code here (it should made more Please close it or whatever. I will re-submit if I ever get round to Cheers Ben On Sun, 15 Jan 2012, Charles Harris wrote:
|
|
OK, I'll close it for now. |
|
Hey, sorry I didn't comment before - what might be nice is to remove the performance improvement (the caching of the dtypes), and consider adding such a caching as a separate feature. The caching belongs somewhere else in the code anyway, as it should bring speed benefits to the datetime code everywhere. |
luyahan
pushed a commit
to plctlab/numpy
that referenced
this pull request
Apr 25, 2024
feat: Add vhsub_s8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I added some code to convert PyDateTime to np.datetime64 automatically, as suggested by Mark. However this change means that np.array([datetime.date(2000, 1, 1)])[0].year would fail. For this reason it's disabled using a preprocessor macro.
I couldn't find a nice way to reuse the logic which decides on NPY_FR_us or NPY_FR_D for PyDateTime or PyDate -- the other place being in convert_pydatetime_to_datetimestruct which performs actual date conversion. But it isn't a great deal of logic anyway :-)
I thought I'd send the code in anyway, just in case it helps.
Cheers
Ben