BUG: ensure extobj and axes have their own references. #11257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 6, 2018
eric-wieser
reviewed
Jun 6, 2018
| @@ -555,8 +555,9 @@ ufunc_get_name_cstr(PyUFuncObject *ufunc) { | |||
| * Parses the positional and keyword arguments for a generic ufunc call. | |||
| * | |||
| * Note that if an error is returned, the caller must free the | |||
| * non-zero references in out_op. This | |||
| * function does not do its own clean-up. | |||
| * non-zero references in out_op. This function does not do its own clean-up. | |||
There was a problem hiding this comment.
It'd be nice to change it so it does this too, but I suppose there's no need for that to be part of this PR
There was a problem hiding this comment.
Yes, I thought about that too, and am happy to do a follow-up PR for that; there is no reason not to clean up.
eric-wieser
reviewed
Jun 6, 2018
| @@ -36,6 +36,10 @@ def test_sig_dtype(self): | |||
| assert_raises(RuntimeError, np.add, 1, 2, signature='ii->i', | |||
| dtype=int) | |||
|
|
|||
| def test_extobj_refcount(self): | |||
| # Should not segfault with USE_DEBUG. | |||
| assert_raises(TypeError, np.add, 1, 2, extobj=[4096], parrot=True) | |||
There was a problem hiding this comment.
invalid_keyword_arg would be a little clearer than parrot
There was a problem hiding this comment.
Hey, I finally got a Monty-Python reference in!
eric-wieser
approved these changes
Jun 6, 2018
|
Yep, this looks pretty straightforward to me. One nit, that you can choose to ignore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #11244, where
get_ufunc_argumentsjust ensures any object from the kwargs has its own reference. Must say I like this better.