MAINT: Extract a helper function to apply __array_wrap__ #11295
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8ade643 to
1efd7d7
Compare
eric-wieser
commented
Jun 10, 2018
| goto fail; | ||
| } | ||
|
|
||
| Py_DECREF(mps[j]); |
There was a problem hiding this comment.
I'm pretty sure that there's a segfault in master for a ufunc with more than one output, where only the second __array_wrap__ fails - this ends up being decref'd both here and in fail.
There was a problem hiding this comment.
Yep, fixed in #11296
eric-wieser
commented
Jun 10, 2018
| PyErr_Clear(); | ||
| res = PyObject_CallFunctionObjArgs(wrap, mps[j], NULL); | ||
| } | ||
| Py_DECREF(wrap); |
There was a problem hiding this comment.
Memory leak here (and in the new version) - this won't get decref'd for the second output if the first fails.
eric-wieser
commented
Jun 10, 2018
| } | ||
|
|
||
| Py_DECREF(mps[j]); | ||
| retobj[i] = res; |
There was a problem hiding this comment.
This memory is also leaked if the second one errors.
|
Closing - I learnt what I needed to here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #9022, since that's segfaulting, and maybe this piece is fine.