Skip to content

MAINT: Don't use dtype strings when the dtypes themselves can be used #11324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2018
Merged

MAINT: Don't use dtype strings when the dtypes themselves can be used #11324

merged 1 commit into from
Jun 13, 2018

Conversation

eric-wieser
Copy link
Member

Extracted from #10151

@eric-wieser eric-wieser changed the title MAINT: Don't use dtype strings when the dtpyes themselves can be used MAINT: Don't use dtype strings when the dtypes themselves can be used Jun 13, 2018
@eric-wieser eric-wieser force-pushed the avoid-using-dtype-name branch from 913ee73 to e6763ed Compare June 13, 2018 08:46
mhvk
mhvk approved these changes Jun 13, 2018
View reviewed changes
Copy link
Contributor

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mattip mattip merged commit 8e3764d into numpy:master Jun 13, 2018
@mattip
Copy link
Member

mattip commented Jun 13, 2018

Thanks Eric

@QuLogic QuLogic mentioned this pull request Mar 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhvk mhvk mhvk approved these changes

Assignees
No one assigned
Labels
03 - Maintenance component: numpy.random
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eric-wieser @mattip @mhvk