Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #11376.
PR #9998 introduced
NpyIter_Close
as part of the public C-API in order to resolve anyWRITEBACK_IF_COPY
semantics after iterator use. This PR removes it entirely, instead resolving writeback semantics inNpyIter_Deallocate
.Changes:
NpyIter_Deallocate
to include writeback resolution if needed via the operand-specific flagNpyIter_Close
, adjust the c-api headers, documentation, and internal code.nditer_deallocate
which is called astp_dealloc
for the pythonnp.nditer
to check if writeback resolution has occurred (via a context manager__exit__
or a direct call tonp.close
), and warn appropriately. This part requires introspection into the NpyIter. I created a non-public function to do so, is there a better way?NpyIter_Deallocate
withoutNpyIter_Close