BUG: Ensure comparisons on scalar strings pass without warning. #11405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
approved these changes
Jun 21, 2018
|
@eric-wieser - thanks for the quick review - will merge when tests pass... |
876e1f8 to
77cc160
Compare
|
Hmm, clearly my own testing setup is not good, not triggering on |
eric-wieser
reviewed
Jun 21, 2018
| # that fact (it likely should be changed). This means that the | ||
| # following works (and returns False) due to dtype mismatch: | ||
| a == [] | ||
| # The empty list is not cast to string, and this used to pass due |
There was a problem hiding this comment.
More accurate would be "The empty list is cast to float64", I think?
There was a problem hiding this comment.
True, but not quite worth rerunning the whole test suite...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Astropy testing (astropy/astropy#7587) found a problem with #11282 - scalar strings and scalar numbers now giving deprecation errors. Turns out to have been the result of an overzealous removal of a test whether
selfwas flexible, something that sadly was not tested at all in our test suite. Fixed here.fixes astropy/astropy#7587