-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
DOC: Recommend the use of np.ndim
over np.isscalar
, and explain the differences
#11882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ccf90b6
to
547c747
Compare
Places where we still use
Places where we shouldn't be using it:
Places where we no longer do because it caused issues:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL! Looks good to me, the table is very informative.
Very informative--I learned a lot just reading this PR. |
@charris, can you restart the appveyor build? Although probably safe to ignore, since this is a doc-only change |
Apparently it is not possible to restart single jobs on AppVeyor |
Right now it's not even possible for me to restart the whole appveyor run, since the appveyor account is not the org one (as discussed elsewhere). Seems wasteful to rerun all the tests on a doc-only just because appveyor failed |
agreed |
Thanks Eric. |
Brought on by #4701